-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Disable LexicographicalAnnotationAttributeListing
#5043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable LexicographicalAnnotationAttributeListing
#5043
Conversation
d106e13
to
f68b088
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
waiting feedback and enabler:
junit-jupiter-engine/src/main/java/org/junit/jupiter/engine/execution/DefaultTestInstances.java
Outdated
Show resolved
Hide resolved
junit-jupiter-params/src/main/java/org/junit/jupiter/params/provider/CsvFileSource.java
Outdated
Show resolved
Hide resolved
error-prone.picnic.tech
featuring Lexicographical
& StaticImport
LexicographicalAnnotationAttributeListing
f68b088
to
afcad28
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this rules does more harm than good. Could you please disable it explicitly (after rebasing on main
) with a comment?
} | ||
|
||
@Category({ "JUnit", "Discovery" }) | ||
@Category({ "Discovery", "JUnit" }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The order is important here.
Thanks, yes of course, its always good to mark rejected stuff for the future. |
LexicographicalAnnotationAttributeListing
LexicographicalAnnotationAttributeListing
afcad28
to
e473a09
Compare
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@API
annotations